Repository navigation
Conversation
Contributor
Author
|
Any plan to forward? It's quite impact to some application that has feature likely destroy webview then create new one as needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeatedly creating and closing windows on macOS retains native window objects and causes excessive memory growth.
The window creation path adds an extra retain to an already-owned
alloc/initresult. The custom view and window delegate deallocators also omit superclass deallocation.Counts and memory below are measured after cooldown. Window counts include both
TaoWindowandNSKVONotifying_TaoWindow. (Operation for 100 times)The change removes the one-object-per-cycle accumulation observed in the baseline. The borderless scenario retains one window and its view, with no delegate remaining; complete native-object release is not claimed.
The
Borderless, hiddenfix still remained101might due to appkit native behavior.Related & Close: #1327, #1363