Make doerner18 configs serializable #122
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those are needed to serialize the ConfigSender and ConfigReceiver.
… ConfigReceiver This is useful in case one wants to persist the result of the key generation to sign later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same pull request as #116 , but from a repository actually owned by my company.
In my company, we needed to persist the result of the doerner18 dkg so that we can sign later on.
To do so, we needed to be able to serialize the Setup generated during the dkg.
This pull requests makes this possible.
I assume that this pull request is far from being ready for merge, but I'm starting the conversation and hoping that you will point me to the changes to be made to eventually be able to merge this upstream.
We are currently using that version of the code in our stack. So far, it works pretty well. We can run key generations and later perform signatures using the marshaled shares without any issue.