Use Float16 only for arm64

[rgoldberg]

Use Float16 only for arm64.

Resolve #109

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the project's architecture support by conditionally compiling Float16 related code. By enclosing Float16 conversions and protocol conformances within arm64-specific preprocessor blocks, the change prevents potential compilation issues on other architectures while maintaining functionality where Float16 is supported. This targeted approach improves the robustness and portability of the codebase.

Highlights

• Conditional Compilation for Float16: The usage of Float16 related functionality has been restricted to arm64 architectures using #if arch(arm64) preprocessor directives. This ensures that Float16 types and their associated conversions and conformances are only compiled when targeting arm64.
• Resolution of Issue Build errors for x86_64 slices because Float16 is unavailable on x86_64 #109: This change directly addresses and resolves issue Build errors for x86_64 slices because Float16 is unavailable on x86_64 #109, likely related to compilation errors or unexpected behavior when Float16 was used on non-arm64 architectures.

Changelog

• Sources/JSONAST/JSON.Node.swift
  • Wrapped the as(_: Float16.Type) method within an #if arch(arm64) block.
• Sources/JSONAST/JSON.Number.swift
  • Enclosed the as(_: Float16.Type) method within an #if arch(arm64) block.
• Sources/JSONDecoding/Conformances/Float16 (ext).swift
  • Wrapped the Float16: JSONDecodable extension within an #if arch(arm64) block.
• Sources/JSONEncoding/Conformances/Float16 (ext).swift
  • Enclosed the Float16: JSONEncodable extension within an #if arch(arm64) block.

Activity

• No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request restricts support for Float16 to the arm64 architecture by wrapping the relevant code in conditional compilation blocks. The changes are applied consistently across JSON.Node.swift, JSON.Number.swift, and the JSONDecodable/JSONEncodable conformance files for Float16. The implementation correctly reflects the stated goal of the pull request.