Skip to content

fixing yielding "HELLO" in pkgs.lib#26

Open
MrMarvel wants to merge 4 commits into
tazjin:masterfrom
MrMarvel:patch-1
Open

fixing yielding "HELLO" in pkgs.lib#26
MrMarvel wants to merge 4 commits into
tazjin:masterfrom
MrMarvel:patch-1

Conversation

@MrMarvel

Copy link
Copy Markdown

#25

Copilot AI review requested due to automatic review settings April 30, 2026 15:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the pkgs.lib README example so that evaluating it returns "HELLO" (rather than yielding a lambda), aligning the documentation with the behavior described in issue #25.

Changes:

  • Wrap the example file-lambda in a function application ((...) {}) so it evaluates to a concrete value.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MrMarvel MrMarvel left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added comment

Comment thread README.md
Comment thread README.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the pkgs.lib README example so it evaluates to "HELLO" (instead of yielding a lambda) by explicitly applying the top-level function.

Changes:

  • Wrap the example lambda in parentheses and apply it to {} so it evaluates immediately.
  • Add an explanatory comment about why the parentheses/application are needed.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
@MrMarvel
MrMarvel requested a review from Copilot April 30, 2026 15:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the pkgs.lib README example to correctly evaluate strings.toUpper "hello" by explicitly applying the top-level function to an argument set, matching the behavior described in Issue #25.

Changes:

  • Wraps the example lambda in parentheses and applies it to {} so it evaluates to "HELLO".
  • Adds an explanatory note about the need for parentheses when applying the function.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the pkgs.lib README example to demonstrate evaluating the expression (instead of returning a lambda), aligning the documentation with the behavior described in Issue #25.

Changes:

  • Wrap the Nix lambda in parentheses and apply it to {} so the snippet evaluates to "HELLO".
  • Add an inline comment explaining why parentheses are required in this case.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MrMarvel MrMarvel left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems ok
@tazjin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants