Skip to content

feat(pop): generate popularity on startup if url is not set#113

Open
maxhbr wants to merge 1 commit into
tazjin:masterfrom
maxhbr:feat/compute_popularity_on_startup
Open

feat(pop): generate popularity on startup if url is not set#113
maxhbr wants to merge 1 commit into
tazjin:masterfrom
maxhbr:feat/compute_popularity_on_startup

Conversation

@maxhbr

@maxhbr maxhbr commented Mar 19, 2021

Copy link
Copy Markdown

No description provided.

@google-cla

google-cla Bot commented Mar 19, 2021

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@maxhbr

maxhbr commented Mar 19, 2021

Copy link
Copy Markdown
Author

Oh, you require a CLA,..

@maxhbr
maxhbr force-pushed the feat/compute_popularity_on_startup branch from 78a8758 to 8fcce3f Compare March 19, 2021 15:14
@google-cla

google-cla Bot commented Mar 19, 2021

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Signed-off-by: Maximilian Huber <maximilian.huber@tngtech.com>
@maxhbr
maxhbr force-pushed the feat/compute_popularity_on_startup branch from 8fcce3f to b440197 Compare March 19, 2021 15:18
@google-cla

google-cla Bot commented Mar 19, 2021

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@tazjin tazjin added the enhancement New feature or request label Mar 19, 2021
@tazjin

tazjin commented Mar 19, 2021

Copy link
Copy Markdown
Owner

Thanks, this is a good idea! Two thoughts:

  • I wonder if this should be on by default. Fetching all the required metadata is quite heavy, so it might be useful to make it opt-in instead.

  • nixery-popcount is also a Go program, maybe its code should be used as a library instead in this use-case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants