This repository was archived by the owner on Jul 30, 2025. It is now read-only.
Fix CUDA linking error by ensuring -fPIC for position-independent code #223
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a linker error when building with feature
cuda, such that nvcc compiled & linked objects get compiled with position-independent code (-fPIC). I noticed that this was not getting done when buildingwhisper-rsinto https://github.com/mz2/pipescribe: when enabling thecudafeature,cargo, the following linker error would occur:I have confirmed this to be fixed with the changes in this PR.