Commented out click_chatter("take!") in CheckIP6Header::simple_action #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… , because it's a too central place, has no huge value, and spams the log full. :)
|
I think that situation should be avoided though, that's why there is a message. But if you have a lot packets that arrive too big at the input, then there's not much choices indeed... The best way would be to print it 10 times and then stop, as done in some places. |
|
Hmm, you're right, limiting to 10 would be nice. And then maybe changing the message to a little bit more descriptive? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commented out click_chatter("take!") in CheckIP6Header::simple_action, because it's a too central place, has no huge value, and spams the log full. :)
Keep up the good work, Tom! Thank you for all your time you put into this project.