[#420]Fix network header offset in VlanEncap #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix incorrect MAC header size calculation in VLANEncap element. Replace sizeof(vlan) with sizeof(click_ether_vlan) to use proper struct size instead of pointer size. This ensures correct network header offset anno in the packet for VLAN encapsulated packets.
dganeshk
temporarily deployed
to
GITLAB_PASSWORD
GitHub Actions
Inactive
|
Ah yes, a missing * so it would take the size of the pointer and not the struct. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect MAC header size calculation in VLANEncap element. Replace sizeof(vlan) with sizeof(click_ether_vlan) to use proper struct size instead of pointer size. This ensures correct network header offset anno in the packet for VLAN encapsulated packets.