Record the gRPC target on cassette interactions - #9
Open
davinat0r wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
targetfield to cassette interactions, capturing the gRPC server address (host:port) each request was recorded against.RecordingChannel/AsyncRecordingChannelset it automatically from their target constructor argument; a pre-seededCassette.targettakes precedence (first-write-wins) if already set.Also adds a
TargetMatcherfor projects that record against multiple hosts and need playback to distinguish interactionsby target.
This is purely additive and backward-compatible — cassette YAMLs recorded before this change simply omit target, load unchanged, and default matching (MethodMatcher) is unaffected.
Checklist
Before Review
Before Merge