Meta: update upload-artifact action prior to deprecation #3506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakkot
approved these changes
Dec 6, 2024
bakkot
added
the
ready to merge
|
I'm assuming this:
isn't going to be a problem. |
|
Correct, since we don't upload jobs in a matrix. I read the docs just in case, and there's a way to merge differently named artifacts anyways, so it'd be a straightforward migration if we were. |
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Dec 6, 2024
ljharb
force-pushed
the
update-actions
branch
from
7f1af1f to
715038e
Compare
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Jan 9, 2025
ljharb
added a commit
to ljharb/ecma262
that referenced
this pull request
Feb 4, 2025
ljharb
force-pushed
the
update-actions
branch
from
267ffc4 to
df36acb
Compare
ljharb
force-pushed
the
update-actions
branch
from
df36acb to
abbb649
Compare
|
ok, so i think that this will work once merged, because the remaining action runs on pull_request_target. So, I'm going to merge this. If it works, great! If not, I'm going to rebase and merge the pending PRs anyways, and then I'll revisit this workflow after plenary. |
ljharb
added a commit
that referenced
this pull request
Feb 18, 2025
ljharb
added a commit
that referenced
this pull request
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/