Editorial: narrow some AO return types and parameter types#3826
Merged
Conversation
|
The rendered spec preview for this PR is available as a single page at https://tc39.es/ecma262/pr/3826 and as multiple pages at https://tc39.es/ecma262/pr/3826/multipage . |
linusg
reviewed
Apr 9, 2026
linusg
approved these changes
Apr 9, 2026
nicolo-ribaudo
approved these changes
Apr 23, 2026
michaelficarra
added
the
ready to merge
Jack-Works
reviewed
May 1, 2026
| 1. Let _isArray_ be ? IsArray(_value_). | ||
| 1. If _isArray_ is *true*, return ? SerializeJSONArray(_state_, _value_). | ||
| 1. If _isArray_ is *true*, then | ||
| 1. Assert: _value_ is an Array. _value_ is not a Proxy. |
Member
There was a problem hiding this comment.
Add this assert on engine262 breaks the following test262 tests:
- staging/sm/RegExp/match-trace.js
- built-ins/JSON/stringify/value-array-proxy.js
- built-ins/JSON/stringify/value-array-abrupt.js
Is this correct?
Member
Author
There was a problem hiding this comment.
No, we actually suspect this is incorrect and will be sending a PR to correct it soon.
Jack-Works
added a commit
to engine262/engine262
that referenced
this pull request
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.