Editorial: Refactor parseInt into more cleanly-separated phases#3841
Open
Editorial: Refactor parseInt into more cleanly-separated phases#3841
Conversation
|
The rendered spec preview for this PR is available as a single page at https://tc39.es/ecma262/pr/3841 and as multiple pages at https://tc39.es/ecma262/pr/3841/multipage . |
michaelficarra
approved these changes
Apr 29, 2026
Member
michaelficarra
left a comment
michaelficarra
left a comment
There was a problem hiding this comment.
LGTM otherwise. You're right, this is a lot better.
…nitialization in parseInt
michaelficarra
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When double-checking how
parseInttreats empty-string input, I found its algorithm to be excessively convoluted.