Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Clean up DurationFormat #963

Merged
merged 9 commits into from
Mar 1, 2025
Merged

Editorial: Clean up DurationFormat #963

merged 9 commits into from
Mar 1, 2025

Conversation

gibson042
Copy link
Contributor

  • emu-format
  • align section order with Editorial: Arrange contents consistently #923
  • replace outdated use of @@toStringTag and "abrupt completion"
  • improve documentation of internal slots
  • simplify resolvedOptions and GetDurationUnitOptions

gibson042 added 9 commits March 1, 2025 12:12
@gibson042
Editorial: emu-format spec/durationformat.html
328cfbc
@gibson042
Editorial: Arrange DurationFormat Objects child sections in conventio…
a9dc56f 
…nal order

Ref tc39#923
@gibson042
Editorial: Arrange Properties of the Intl.DurationFormat Prototype Ob…
85c3dbb 
…ject child sections in conventional order

Ref tc39#923
@gibson042
Editorial: Remove a DurationFormat note that was only relevant before…
6daf2f2 
… merging into the full spec
@gibson042
Editorial: Replace outdated use of @@toStringTag with %Symbol.toStrin…
71209ff 
…gTag%
@gibson042
Editorial: Replace outdated use of "abrupt completion" with the more …
249c9c7 
…precise "throw completion"
@gibson042
Editorial: Better document internal slots of Intl.DurationFormat
53b144a
@gibson042
Editorial: Simplify Intl.DurationFormat.prototype.resolvedOptions
8036e8c
@gibson042
Editorial: Simplify GetDurationUnitOptions
20daf26
@gibson042 gibson042 requested a review from ryzokuken March 1, 2025 20:44
@gibson042 gibson042 mentioned this pull request Mar 1, 2025
Merged
ryzokuken
ryzokuken approved these changes Mar 1, 2025
View reviewed changes
Copy link
Member

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ryzokuken ryzokuken merged commit d097048 into tc39:main Mar 1, 2025
2 checks passed
@gibson042 gibson042 mentioned this pull request Mar 3, 2025
Merged
@sffc
Copy link
Contributor

sffc commented Mar 3, 2025

These changes should be in ES 2025. Can we fast-forward the es2025 branch? In general, I'd like to see this as well as some of @gibson042's other editorial PRs land in ES 2025.

gibson042 added a commit to gibson042/ecma402 that referenced this pull request Mar 4, 2025
@gibson042
Editorial: Explain ValidateDurationUnitStyle parameter "unit"
208f69b 
Ref tc39#963
Ref tc39#969
@gibson042 gibson042 mentioned this pull request Mar 4, 2025
Merged
ryzokuken pushed a commit that referenced this pull request Mar 5, 2025
@gibson042 @ryzokuken
Editorial: Explain ValidateDurationUnitStyle parameter "unit"
16c4011 
Ref #963
Ref #969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzokuken ryzokuken ryzokuken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
ECMA-402 Meeting Topics
Status: Previously Discussed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gibson042 @sffc @ryzokuken