-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notes + summaries for July 2023 #281
Conversation
@littledan is this the Samina version referred to in #268 (comment) ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only reviewed the last commit; in general, please condense multiple spaces to 1, and we generally only use acronyms to refer to people in the notes.
might be able to take care of this via the lexer. I'll have a go |
@ctcpip note that it shouldn't be condensed when it's indentation (start of line), or table spacing (like in the notes table) |
no worries, the existing test files should cover this. and the indentation at start of line shouldn't be where there is plain text (what the lexer detects as a paragraph), but can you provide an example of indentation that is expected? e.g. indenting a list wouldn't apply here |
sounds like it'd be fine, just was making sure to call it out |
sure, just want to make sure we don't need to add anything to the test sample |
💥 #282 💥 |
https://github.com/acutmore/notes/pull/1/files
|
unfortunately since the summaries and notes are being landed together, i can't easily review just the formatted summaries :-/ |
I quickly skimmed the summaries/conclusions for problems but not substance... anyway, the whitespace should all be addressed and I fixed the non-TLA name references that appeared in conclusions/summaries |
Thank you so much @ctcpip ! |
Like #268 but with updated summaries.