Editorial: Add a note about the possibility of deferring getting the list of exports - #69
Open
nicolo-ribaudo wants to merge 2 commits into
Open
Editorial: Add a note about the possibility of deferring getting the list of exports#69nicolo-ribaudo wants to merge 2 commits into
nicolo-ribaudo wants to merge 2 commits into
Conversation
Collaborator
|
This does seem preferable to #68, noting laziness as a property implementations can use as opposed to trying to hard code it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A goal of the proposal is that implementations can, under some circumstances, easily implement lazy loading of deferred modules (when they know that they don't have syntax errors or transitive async dependencies). While trying to actually implement an example of that, I found a problem: even though it's not user-exposed, the spec eagerly reads the list of exports in GetModuleNamespace.
This PR centralized the logic to get and sort the list of names in a single place, and adds a note explaining that it's a pure operation and thus can actually be deferred if needed for implementation purposes.
Closes #68