Skip to content

Fixing values from Import/Export Entry's [[ImportName]] - #37

Merged
caiolima merged 1 commit into
tc39:mainfrom
caiolima:fix-wrong-assertion
May 7, 2026
Merged

Fixing values from Import/Export Entry's [[ImportName]]#37
caiolima merged 1 commit into
tc39:mainfrom
caiolima:fix-wrong-assertion

Conversation

@caiolima

@caiolima caiolima commented May 7, 2026

Copy link
Copy Markdown
Collaborator

This change aligns expected values from Import/Export Entry of [[ImportName]] to use ~namespace~ instead of ~namespace-object~ and ~all~.

It fixes #35.

@caiolima
caiolima requested a review from nicolo-ribaudo May 7, 2026 14:33
This change aligns expected values from Import/Export Entry of
[[ImportName]] to use ~namespace~ instead of ~namespace-object~ and
~all~.
@caiolima
caiolima force-pushed the fix-wrong-assertion branch from 54d1a56 to bd44396 Compare May 7, 2026 14:34

@nicolo-ribaudo nicolo-ribaudo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check that this is complete, mostly trusting you to have properly Ctrl+F'ed for ~namespace-object~ and ~all~.

@caiolima

caiolima commented May 7, 2026

Copy link
Copy Markdown
Collaborator Author

I didn't check that this is complete, mostly trusting you to have properly Ctrl+F'ed for ~namespace-object~ and ~all~.

This just changes ~all~ from [[ImportName]]. We are still using all on importNames through this spec, but I don't think we are planning to change those.

@caiolima
caiolima merged commit 077b131 into tc39:main May 7, 2026
1 check passed
@caiolima
caiolima deleted the fix-wrong-assertion branch May 7, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong assertion on GetOptionalIndirectExportsModuleRequests

2 participants