Make Duration _repr_ match toString() output

[justingrant]

Fixes #1371

[codecov]

Codecov Report

Merging #1375 (88a6dff) into main (b7c4ac8) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1375      +/-   ##
==========================================
- Coverage   95.26%   95.24%   -0.02%     
==========================================
  Files          19       19              
  Lines       11123    11125       +2     
  Branches     1824     1824              
==========================================
  Hits        10596    10596              
- Misses        522      524       +2     
  Partials        5        5              

Flag	Coverage Δ
test262	48.45% <ø> (ø)
tests	90.96% <0.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
polyfill/lib/duration.mjs	97.52% <0.00%> (-0.31%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7c4ac8...cab49a8. Read the comment docs.

[ptomato]

Good catch, I had found the other day that this was broken in toJSON() and included a fix in #1370 but had missed this one.

It should be OK to just add ES.TemporalDurationToString(this, 'auto') though.

[justingrant]

Good catch, I had found the other day that this was broken in toJSON() and included a fix in #1370 but had missed this one.

It should be OK to just add ES.TemporalDurationToString(this, 'auto') though.

Given that #1370 seems to fix most of these cases, do you want to just fix _repr_ in #1370 too instead of spreading fixes for essentially the same bug across multiple PRs?

BTW, instead of updating all callsites to use an 'auto' parameter, would a better fix be to treat undefined as 'auto' in ES.TemporalDurationToString? It seems odd that the default behavior of ES.TemporalDurationToString isn't the same as 'auto'.

[ptomato]

Yeah, makes sense. I'll close this and pull out that fix from the other PR into a new PR.