Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-resolve unresolvable references on the global in PutValue. Supports tc39/ecma262#2205 #2891

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rwaldron
Copy link
Contributor

@rwaldron rwaldron commented Nov 2, 2020

@rwaldron rwaldron added the awaiting consensus This needs committee consensus before it can be eligible to be merged. label Nov 4, 2020
@rwaldron rwaldron requested a review from jugglinmike January 18, 2021 17:53
flags: [onlyStrict]
---*/

undeclared = (globalThis.undeclared = 5);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand how the globalThis binding is related to the normative change. By my reading, this test only differs from the existing test in that it also includes semantics that are verified by test/built-ins/global/global-object.js.


flags: [onlyStrict]
negative:
phase: runtime
type: ReferenceError
---*/

undeclared = (this.undeclared = 5);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we're expecting this test to execute, we should include an assertion for the result of the expression, like assert.sameValue(undeclared, 5);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting consensus This needs committee consensus before it can be eligible to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants