Test normative changes in ECMA-402 #715 #3679
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptomato
approved these changes
Sep 30, 2022
| @@ -21,11 +23,8 @@ const invalidOptions = [ | |||
| "full", | |||
| "numeric", | |||
| -1, | |||
| 4, | |||
There was a problem hiding this comment.
I would recommend replacing the removed lines with new values that are still invalid. E.g. 10, "10", and 9.000001.
Comment on lines
-30
to
-33
| assert.throws(RangeError, () => { | ||
| new Intl.DateTimeFormat( | ||
| 'en', { minute: "numeric", second: "numeric", fractionalSecondDigits: 0}); | ||
| }, "fractionalSecondDigits 0 should throw RangeError for out of range"); |
There was a problem hiding this comment.
I'd recommend keeping these out-of-range tests but changing the values from 0 and 4, to -1 and 10.
Comment on lines
-34
to
-42
| assert.throws(RangeError, () => { | ||
| new Intl.DateTimeFormat( | ||
| 'en', { minute: "numeric", second: "numeric", fractionalSecondDigits: 0}); | ||
| }, "fractionalSecondDigits 0 should throw RangeError for out of range"); | ||
|
|
||
| assert.throws(RangeError, () => { | ||
| new Intl.DateTimeFormat( | ||
| 'en', { minute: "numeric", second: "numeric", fractionalSecondDigits: 4}); | ||
| }, "fractionalSecondDigits 4 should throw RangeError for out of range"); |
There was a problem hiding this comment.
Same, I'd recommend testing -1 and 10.
| assert.throws(RangeError, () => { | ||
| new Intl.DateTimeFormat( | ||
| 'en', { minute: "numeric", second: "numeric", fractionalSecondDigits: 4}); | ||
| }, "fractionalSecondDigits 4 should throw RangeError for out of range"); | ||
|
|
||
| let dtf = new Intl.DateTimeFormat( |
There was a problem hiding this comment.
Should this one test the same values that you're looping over in the other test files? (undefined, 0, "0", etc)
| @@ -7,7 +8,8 @@ description: > | |||
| Checks error cases for the options argument to the DateTimeFormat constructor. | |||
| info: | | |||
| InitializeDateTimeFormat ( dateTimeFormat, locales, options ) | |||
| 23. Let _opt_.[[FractionalSecondDigits]] be ? GetNumberOption(_options_, `"fractionalSecondDigits"`, 0, 3, 0). | |||
| 1. Let _value_ be ? GetNumberOption(_options_, *"fractionalSecondDigits"*, 0, 9, *undefined*). | |||
| 1. If _value_ is one of *"0"*, *"4"*, *"5"*, *"6"*, *"7"*, *"8"*, *"9"*, set _value_ to *undefined*. | |||
There was a problem hiding this comment.
(See my comment in the ECMA-402 PR about this line of the spec text)
ptomato
added
the
awaiting consensus
Ms2ger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test normative change in tc39/ecma402#715