Increase coverage for dynamic import and top-level await #4421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
commented
Mar 12, 2025
Comment on lines
+50
to
+56
| // We only continuye execution of the first fixture file after importing a second, | ||
| // empty, fixture file. This is so that if the implementation uses a separate | ||
| // queue to resolve dynamic import promises, if dynamic-import-of-waiting-module_FIXTURE | ||
| // wasn't waiting on top-level await its top-level promise would already be resolved. | ||
| import("./dynamic-import-of-waiting-module-2_FIXTURE.js").then(() => { | ||
| continueExecution(); | ||
| }, $DONE); |
There was a problem hiding this comment.
This is not super nice but I don't know how else to give promiseForNamespace2 a chance to resolve before calling continueExecution. The expected behavior is that promiseForNamespace2 will not resolve before that call, so I cannot simply move continueExecution() into a .then handler on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two failing cases we found in JSC while running the import defer tests, for which we didn't have previous coverage. Given that dynamic import and top level await are features on their own, it's better to also have tests for it that do not use import defer.
What these tests are testing is that dynamic import of a module that is already rejected/pending returns a promise that is rejected/pending.