Skip to content

Intl: Add coverage for ToIntlMathematicalValue constraints#4936

Open
gibson042 wants to merge 6 commits intotc39:mainfrom
gibson042:gh-4933-intl-mathematical-bounds
Open

Intl: Add coverage for ToIntlMathematicalValue constraints#4936
gibson042 wants to merge 6 commits intotc39:mainfrom
gibson042:gh-4933-intl-mathematical-bounds

Conversation

@gibson042
Copy link
Member

Fixes #4933
Extends and replaces #4780

  • Tests against current spec text rather than Normative: Increase limits on Intl MV and explicitly limit significant digits ecma402#1022
  • Adds more context, in particular showing use of RoundMVResult only to identify special values (and not e.g. to round over-precise in-bounds values)
  • Removes the presumption of BigInt support
  • Covers both sides of the treat-as-infinite transition
  • Includes literal decimal/hexadecimal/binary/octal string values (along with their derivation)
    • If we do extend to 1000 decimal digits, I expect such literals to be replaced with string operations like repeat and/or replace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Probably missing coverage for ECMA-402 ToIntlMathematicalValue

3 participants