Add return-abrupt-from-this-length tests for Change Array by Copy methods #4951
Open
Add return-abrupt-from-this-length tests for Change Array by Copy methods #4951
Conversation
dmvjs
changed the title
…hods Mirrors the existing pattern in findLast and findLastIndex.
dmvjs
force-pushed
the
add/toreversed-abrupt-from-length
branch
from
fd262ca to
50bb04e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toReversed, toSorted, toSpliced, and with are all missing coverage for the abrupt completion in step 2 (LengthOfArrayLike). Mirrors the existing pattern in findLast and findLastIndex.