[import-defer]: Adding test to validate deferred namespaces exports#4962
Open
[import-defer]: Adding test to validate deferred namespaces exports#4962
Conversation
This tests the case for `import defer * as ns from 'dep'; export {ns};`.
nicolo-ribaudo
approved these changes
Mar 2, 2026
Member
nicolo-ribaudo
left a comment
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Looks good, thank you!
Comment on lines
+31
to
+35
| assert.compareArray(globalThis.evaluations, ["reexport"], | ||
| "deferred module should not be evaluated"); | ||
|
|
||
| assert.sameValue(ns[Symbol.toStringTag], "Deferred Module", | ||
| "'ns' should be a deferred namespace object"); |
Member
There was a problem hiding this comment.
Before the linked spec change, both these assertions will fail.
nicolo-ribaudo
added
the
awaiting consensus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tests the case for
import defer * as ns from 'dep'; export {ns};.It adds a case for the change in tc39/proposal-defer-import-eval#79