Test language preference in Intl.Locale.p.getHourCycles - #5091
Merged
ptomato merged 1 commit intoJul 23, 2026
Merged
Conversation
ptomato
added
needs review
awaiting consensus
ptomato
marked this pull request as draft
July 21, 2026 22:13
Contributor
Author
|
This normative PR is up for consensus in the TC39 meeting on Wednesday; draft until then. |
gibson042
approved these changes
Jul 22, 2026
This test is for the normative PR tc39/ecma402#1086, where getHourCycles() and getCalendars() are changing to use language-region data if available, instead of just region-specific. It is not possible to write a test for getCalendars() since currently there are no known implementations where language-region-specific calendar preferences exist. LLM disclosure: I used a bot to search for suitable input locale candidates. I also used the same bot for a first draft of the test file, although I basically discarded the result.
ptomato
force-pushed
the
ecma402-1086-language-preference-locale-gethourcycles
branch
from
July 23, 2026 00:42
97107ca to
64a7136
Compare
ptomato
marked this pull request as ready for review
July 23, 2026 00:43
ptomato
added
has consensus
ptomato
deleted the
ecma402-1086-language-preference-locale-gethourcycles
branch
July 23, 2026 00:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is for the normative PR tc39/ecma402#1086, where getHourCycles() and getCalendars() are changing to use language-region data if available, instead of just region-specific.
It is not possible to write a test for getCalendars() since currently there are no known implementations where language-region-specific calendar preferences exist.
LLM disclosure: I used a bot to search for suitable input locale candidates. I also used the same bot for a first draft of the test file, although I basically discarded the result.