add graceful shutdown for docker #2126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Execute java process with PID=1 through replacing the existing process with the java process. This is required for docker based execution as docker forwards SIGINT to the process with PID=1. In case the process cannot handle it, the signal is ignored and docker forcefully kills the container after a certain grace period leading to an exit code of 137.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execute java process with PID=1 through replacing the existing process with the java process. This is required for docker based execution since docker forwards SIGINT to the process with PID=1. In case the process cannot handle it (which was the case prior to this PR), the signal is ignored and docker forcefully kills the container after a certain grace period leading to an exit code of 137.
This PR fixes: #2146