feat(helm): add startup probe support to deployment template#2768
Open
TwoStone wants to merge 1 commit intotchiotludo:devfrom
Open
feat(helm): add startup probe support to deployment template#2768TwoStone wants to merge 1 commit intotchiotludo:devfrom
TwoStone wants to merge 1 commit intotchiotludo:devfrom
Conversation
Add a configurable startupProbe to the Helm chart, following the same pattern as the existing readinessProbe and livenessProbe. The startup probe is disabled by default to avoid breaking existing deployments. When enabled, it uses the /health endpoint on the management port with a failureThreshold of 30 and periodSeconds of 10, allowing up to ~5 minutes for the application to start.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a configurable
startupProbeto the Helm chart deployment template, following the same pattern as the existingreadinessProbeandlivenessProbe.Motivation
Startup probes are useful for applications that have slow startup times. Unlike liveness probes, the startup probe only runs during initial container startup, preventing Kubernetes from killing pods that are still initializing. This is especially relevant for AKHQ when connecting to large Kafka clusters where the initial health check may take longer.
Changes
helm/akhq/templates/deployment.yaml— AddedstartupProbeblock after thereadinessProbe, with the same configurable fields (httpGet,prefix,path,port,httpGetExtra, and all timing parameters).helm/akhq/values.yaml— Added defaultstartupProbeconfiguration:enabled: false) to avoid breaking existing deployments/healthendpoint on themanagementportinitialDelaySeconds: 0,periodSeconds: 10,failureThreshold: 30— allows up to ~5 minutes for the application to startUsage
Enable the startup probe in your values override: