Shell script (mostly awk) for pulling file lists from bodyfile.#432
Merged
Conversation
Signed-off-by: Hal Pomeranz <hrpomeranz@gmail.com>
Realized that if we pass in null uidlist or gidlist values then every file and directory will be marked as unowned. Added new conditional test to fix. Signed-off-by: Hal Pomeranz <hrpomeranz@gmail.com>
Owner
|
I noticed you are filtering out only directories from world writable files. I did a test and it seems that all symlinks are also returned as they tend to be 666 or 777. I was thinking about filtering out symlinks as well. |
Contributor
Author
|
I don't see how matching symlinks is possible. The pattern match on line 70 in the code is |
Owner
|
Forget about what I said... my bad. |
Update artifacts and profiles. Update bodyfile2filelists.sh to support systems other than Linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ended up refactoring the original bodyfile2filelists.sh into a version that mostly uses awk for the heavy lifting. The awk version runs orders of magnitude faster than my initial attempt as a portable Bourne shell script that called out to grep each time it needed to do a pattern match.
This is apropos of Issue #416