Skip to content

feat: ensure trailing newline with comment-only queries#703

Merged
tconbeer merged 4 commits into
tconbeer:mainfrom
snrsw:fix/trailing-newline-with-comments
Oct 17, 2025
Merged

feat: ensure trailing newline with comment-only queries#703
tconbeer merged 4 commits into
tconbeer:mainfrom
snrsw:fix/trailing-newline-with-comments

Conversation

@snrsw

@snrsw snrsw commented Aug 9, 2025

Copy link
Copy Markdown
Contributor

Closes #686

This PR resolves comment-only file formatting to remove unnecessary newlines

@snrsw snrsw marked this pull request as ready for review August 9, 2025 17:22
@snrsw snrsw marked this pull request as draft August 10, 2025 04:31
@snrsw snrsw marked this pull request as ready for review August 10, 2025 04:34
@tconbeer

Copy link
Copy Markdown
Owner

Thanks for this one also! Going to poke around here a little and see if we can make a change farther inside the comment-rendering machinery. Having a failing test to work with is always a nice start, though.

@tconbeer tconbeer merged commit 2eb39c7 into tconbeer:main Oct 17, 2025
18 of 29 checks passed
@snrsw snrsw deleted the fix/trailing-newline-with-comments branch November 5, 2025 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sqlfmt adds a second trailing newline in files that end with a comment.

2 participants