Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanups #338

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Code cleanups #338

wants to merge 1 commit into from

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Mar 31, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.32%. Comparing base (bac5a57) to head (2def472).
Report is 115 commits behind head on master.

Files with missing lines Patch % Lines
src/main/java/org/vafer/jdependency/Clazz.java 25.00% 3 Missing ⚠️
src/main/java/org/vafer/jdependency/Clazzpath.java 83.33% 0 Missing and 1 partial ⚠️
...a/org/vafer/jdependency/utils/DependencyUtils.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #338      +/-   ##
============================================
+ Coverage     79.07%   79.32%   +0.24%     
+ Complexity       72       70       -2     
============================================
  Files             6        6              
  Lines           239      237       -2     
  Branches         27       27              
============================================
- Hits            189      188       -1     
+ Misses           37       36       -1     
  Partials         13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tcurdt
Copy link
Owner

tcurdt commented Mar 31, 2025

Thanks for the contribution but I don't subscribe to all those changes.
Could you please provide some context?

Copy link
Contributor Author

@Goooler Goooler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of them are minor cleanups, such as

  • Remove unnecessary \\ in regex.
  • Mark final fields.
  • Mark @Override and align the parameters with the parents.
  • Use isEmpty checks.
  • Use method refs.
  • Remove unnecessary type parameters in collections.
  • Inline values.
  • Use Set.of, List.of, and so on.
  • Fix parameter orders of assertEquals.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class seems unused in any way and could be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants