-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code cleanups #338
base: master
Are you sure you want to change the base?
Code cleanups #338
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #338 +/- ##
============================================
+ Coverage 79.07% 79.32% +0.24%
+ Complexity 72 70 -2
============================================
Files 6 6
Lines 239 237 -2
Branches 27 27
============================================
- Hits 189 188 -1
+ Misses 37 36 -1
Partials 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks for the contribution but I don't subscribe to all those changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of them are minor cleanups, such as
- Remove unnecessary
\\
in regex. - Mark
final
fields. - Mark
@Override
and align the parameters with the parents. - Use
isEmpty
checks. - Use method refs.
- Remove unnecessary type parameters in collections.
- Inline values.
- Use
Set.of
,List.of
, and so on. - Fix parameter orders of
assertEquals
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class seems unused in any way and could be removed.
No description provided.