This repository was archived by the owner on Aug 13, 2025. It is now read-only.
fix: new empty row index bug #820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If saved, the data in the first row will be cleared. 
|
|
Thank you for your work @lpxxn - much appreciated! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will introduce a bug.
https://github.com/tealeg/xlsx/pull/819/files#diff-736c5868afcf3093a503fb89211daa2dca5ba2b9e2c8fbe5dc105fbbd0e7b963R307
The newly added row index is incorrect, and when reading the data from the row again, it will be empty.