Skip to content
This repository was archived by the owner on Aug 13, 2025. It is now read-only.

Conversation

@knubix
Copy link
Contributor

@knubix knubix commented Sep 19, 2024

Solving following issue:
I am reading a sheet from an existing xlsx file with ValueOnly() and replacing some spaceholder strings with ForEachRow and ForEachCell with SkipEmptyRows and SkipEmptyCells as parameters. Saving the results Save() serializes the xlsx file into file, with empty cells covering my celloverflowing replacements.

The actual code skips only empty rows. This pull request adds the SkipEmptyCells to ForEachCell during serialization and avoids unnecessary cells.

…l; avoid unnecessary empty cells in final sheet covering longer cells left of them
Copy link
Owner

@tealeg tealeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 like it!

@tealeg tealeg merged commit cbf4534 into tealeg:master Sep 22, 2024
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants