feat: add microsoft strategy#1136
Merged
jimsynz merged 7 commits intoteam-alembic:mainfrom Mar 10, 2026
Merged
Conversation
Collaborator
|
Thanks for putting this together! A Microsoft strategy is something we've been wanting — really keen to get this merged. I'll do a code review shortly. |
Contributor
Author
|
I had some issues with multi-tenancy I'm adding the fix/feat shortly (: |
847f061 to
561973e
Compare
Contributor
Author
|
Fixed the |
jimsynz
requested changes
Mar 9, 2026
Collaborator
jimsynz
left a comment
There was a problem hiding this comment.
Nice work — this follows the same pattern as the other wrapper strategies and the multi-tenant issuer handling is well thought out. Just two small things to address before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I use
ash_authenticationfor my Phoenix projects, and I really like it. I couldn't see a Microsoft strategy, so I thought I would add one and I hope this is a welcome improvement. I've made the tutorial and DSL so it's quite similar to other strategies.There were a few catches:
/common/v2.0or/{tenant_id}/v2.0depending on your app registration, so I opted for allowing the user to override with the fullbase_urlinstead.