fix: use raw paths for reset/register route definitions in sign_in_route

When `sign_in_route` is used inside a Phoenix router `scope`, the
reset and register routes were double-nested. For example, inside
`scope "/admin"`, a `reset_path: "/reset"` would generate a route at
`/admin/admin/reset` instead of `/admin/reset`.

The sign-in route itself was unaffected because it used the raw path
option (`unquote(path)`) in the `live/4` call, letting the Phoenix
scope mechanism add the prefix once. However, `reset_path` and
`register_path` were passed through `Phoenix.Router.scoped_path/2`
(which adds the scope prefix) and then used directly in `live/4`
(which adds the scope prefix again).

The fix maintains separate variables: the scoped paths are still used
in session data (so the LiveView generates correct links), while the
raw paths are used for route definitions.

Fixes team-alembic/ash_authentication#1151

Author: jimsynz

lib/ash_authentication_phoenix/router.ex

@@ -351,13 +351,27 @@ defmodule AshAuthentication.Phoenix.Router do
             value -> Phoenix.Router.scoped_path(__MODULE__, value)
           end
 
+        register_route_path =
+          case unquote(register_path) do
+            nil -> nil
+            {:unscoped, value} -> value
+            value -> value
+          end
+
         reset_path =
           case unquote(reset_path) do
             nil -> nil
             {:unscoped, value} -> value
             value -> Phoenix.Router.scoped_path(__MODULE__, value)
           end
 
+        reset_route_path =
+          case unquote(reset_path) do
+            nil -> nil
+            {:unscoped, value} -> value
+            value -> value
+          end
+
         auth_routes_prefix =
           case unquote(auth_routes_prefix) do
             nil -> nil
@@ -396,11 +410,11 @@ defmodule AshAuthentication.Phoenix.Router do
           live(unquote(path), unquote(live_view), :sign_in, as: unquote(as))
 
           if reset_path do
-            live(reset_path, unquote(live_view), :reset, as: :"#{unquote(as)}_reset")
+            live(reset_route_path, unquote(live_view), :reset, as: :"#{unquote(as)}_reset")
           end
 
           if register_path do
-            live(register_path, unquote(live_view), :register, as: :"#{unquote(as)}_register")
+            live(register_route_path, unquote(live_view), :register, as: :"#{unquote(as)}_register")
           end
         end
       end

test/router_test.exs

@@ -31,10 +31,9 @@ defmodule AshAuthentication.Phoenix.RouterTest do
   end
 
   test "sign_in_routes respects the inherited router scope" do
-    route =
-      AshAuthentication.Phoenix.Test.Router
-      |> Phoenix.Router.routes()
-      |> Enum.find(&(&1.path == "/nested/sign-in"))
+    routes = Phoenix.Router.routes(AshAuthentication.Phoenix.Test.Router)
+
+    route = Enum.find(routes, &(&1.path == "/nested/sign-in"))
 
     {_, _, _, %{extra: %{session: session}}} = route.metadata.phoenix_live_view
 
@@ -52,6 +51,12 @@ defmodule AshAuthentication.Phoenix.RouterTest do
                   "resources" => nil
                 }
               ]}
+
+    assert Enum.find(routes, &(&1.path == "/nested/reset")),
+           "reset route should be at /nested/reset, not /nested/nested/reset"
+
+    assert Enum.find(routes, &(&1.path == "/nested/register")),
+           "register route should be at /nested/register, not /nested/nested/register"
   end
 
   test "sign_in_routes respects unscoped" do