fix: respect override for submit_label in Confirm.Input component#717
Merged
jimsynz merged 1 commit intoteam-alembic:mainfrom Feb 18, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug in the Confirm.Input component where the submit_label property ignored user-configured overrides. Previously, the component always returned a hardcoded default label ("Confirm Your {field}"), even when users set custom values via override modules.
Changes:
- Modified
submit_labelassignment to check for overrides first before falling back to the default humanized value - Aligns the
Confirm.Inputcomponent with the override pattern used consistently across other components likeMagicLink.Input
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Confirm.Inputcomponent'ssubmit_labelignored user-configured overrides.Setting
set :submit_label, "Verify Email"(or any custom value) in an overridemodule had no effect — the component always returned the hardcoded default
(
"Confirm Your {field}").Fix
Check
override_for/2first and fall back to the default only when no override is set: