feat: extract sign-in setup task, register OAuth strategies#725
Merged
feat: extract sign-in setup task, register OAuth strategies#725
Conversation
…ster OAuth strategies - New `ash_authentication_phoenix.setup` task extracts sign-in infrastructure (AuthController, routes, pipeline plugs, LiveUserAuth, overrides, tailwind) from the install task into a standalone, composable task - Install task now composes with setup instead of inlining the logic, eliminating code duplication for security-critical auth infrastructure - Register all 8 OAuth/OIDC strategies in the AAP dispatcher, pointing to the setup task for Phoenix-side integration - OAuth strategies auto-render as buttons in the sign-in page via the strategy's `icon` field — no provider-specific Phoenix components needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ash_authentication_phoenix.setuptask extracts sign-in infrastructure (AuthController, routes, pipeline plugs, LiveUserAuth, overrides, tailwind) from the install task into a standalone, composable tasksetupinstead of inlining the logic — single source of truth for security-critical auth infrastructuresetuptask for Phoenix-side integrationiconfieldCompanion to team-alembic/ash_authentication#1149
Test plan
mix check— dialyzer pre-existing failure unrelated)--warnings-as-errorsmix ash_authentication_phoenix.add_strategy githubsets up routes + sign-in pagesetuptask is idempotent (second run is no-op)mix igniter.install ash_authentication_phoenixstill works identically