π :: (#176) Ready For Deployment #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iloveuhyeon
requested review from
aiden30015,
answad,
audgns10,
Copilot and
nahyunuk
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the app for deployment by adjusting UI layouts, adding scrollable wrappers, implementing logout/withdraw flows, and updating navigation targets.
- Wrapped several screens in scroll views and adjusted padding/spacing.
- Introduced
LogoutProfileandWithdrawProfileevents with UI buttons and Bloc handling. - Updated navigation logic in login, home, and community detail screens.
- Removed responsive
.spsizing and inserted fixed pixel values (potential regression). - Added debug
print(e)statements inStageBloc.
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pubspec.yaml | Removed trailing whitespace |
| lib/presentation/team_create/screen/team_place_screen.dart | Made content scrollable and tweaked spacing/padding |
| lib/presentation/team_create/screen/team_create_screen.dart | Added scroll container and adjusted bottom padding |
| lib/presentation/stage_create/widgets/stage_student_manage_popup.dart | Wrapped popup content in SingleChildScrollView |
| lib/presentation/stage/bloc/stage_bloc.dart | Added debug print(e) calls |
| lib/presentation/profile/screen/profile_screen.dart | Added logout/withdraw buttons |
| lib/presentation/profile/bloc/profile/profile_event.dart | Defined LogoutProfile and WithdrawProfile events |
| lib/presentation/profile/bloc/profile/profile_bloc.dart | Handled logout/withdraw events |
| lib/presentation/logIn/screen/login_screen.dart | Changed post-login route to stage |
| lib/presentation/logIn/bloc/login_bloc.dart | Modified case logic for Authority.USER |
| lib/presentation/home/widgets/appbar/home_appbar.dart | Hardcoded now date |
| lib/presentation/home/screen/home_screen.dart | Updated context.pushNamed parameters |
| lib/presentation/community/screen/community_detail_screen.dart | Refactored image loading and formatting |
| lib/presentation/match_detail/widget/match_state_widget.dart | Replaced responsive .sp units with fixed pixels |
| lib/design_system/component/tag/gogo_borderless_tag_component.dart | Centered tag content |
Comments suppressed due to low confidence (3)
lib/presentation/logIn/bloc/login_bloc.dart:56
- Dart
caselabels cannot use a boolean expression. HandleAuthority.USERandAuthority.STAFFin separatecasestatements or use aswitchfall-through pattern.
case Authority.USER || Authority.STAFF:
lib/presentation/home/widgets/appbar/home_appbar.dart:26
- The date is hardcoded to April 20, 2025. Replace with
DateTime.now()to reflect the actual current date.
final now = DateTime(2025,04,20);
lib/presentation/match_detail/widget/match_state_widget.dart:49
- Removing
.spresponsive units in favor of fixed pixel values may break designs on different screen sizes. Consider restoring responsive sizing.
width: 16,
| stream_transform: ^2.1.1 # streamμ concurrencyλ₯Ό λμμ£Όλ λΌμ΄λΈλ¬λ¦¬ | ||
|
|
||
| image_picker: ^1.1.2 # μ΄λ―Έμ§ μ ν λΌμ΄λΈλ¬λ¦¬ | ||
|
|
There was a problem hiding this comment.
Remove the extra blank line containing only whitespace to avoid trailing spaces in pubspec.yaml.
Suggested change
| SearchStageResponse stage = await _stageRepository.getAllStages(); | ||
| emit(StageLoaded(stage: stage)); | ||
| } catch (e) { | ||
| print(e); |
There was a problem hiding this comment.
Remove this debug print(e) statement or replace it with proper logging to avoid printing exceptions in production.
Suggested change
| print(e); | |
| log(e.toString()); |
| try { | ||
| await _stageRepository.joinStage(event.stageId, event.body); | ||
| } catch (e) { | ||
| print(e); |
There was a problem hiding this comment.
Remove this debug print(e) statement or replace it with proper logging to avoid printing exceptions in production.
Suggested change
| print(e); | |
| log(e.toString(), name: 'StageBloc'); |
| Future<void> _withdrawProfile( | ||
| WithdrawProfile event, Emitter<ProfileState> emit) async { | ||
| try { | ||
| await authRepository.logOut(); |
There was a problem hiding this comment.
In _withdrawProfile, calling logOut() likely should be a withdrawal or account deletion API, not a logout. Update to call the correct repository method.
Suggested change
| await authRepository.logOut(); | |
| await authRepository.withdrawAccount(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π‘ κ°μ
π μμ λ΄μ©
πββοΈ μ§λ¬Έμ¬ν
π΄ μ¬μ©λ°©λ²