Skip to content

Conversation

@iloveuhyeon
Copy link
Collaborator

πŸ’‘ κ°œμš”

match list page에 api μ—°κ²°ν–ˆμŠ΅λ‹ˆλ‹€

πŸ“ƒ μž‘μ—…λ‚΄μš©

πŸ™‹β€β™‚οΈ μ§ˆλ¬Έμ‚¬ν•­

  • κ°œμ„ ν•  점, μ˜€νƒ€, μ½”λ“œμ— μ΄μƒν•œ 뢀뢄이 μžˆλ‹€λ©΄ Comment λ‹¬μ•„μ£Όμ„Έμš”.

🍴 μ‚¬μš©λ°©λ²•

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR connects the match list page to the backend API and integrates state management for loading and displaying match data.

  • Adds a new GoRoute for the MatchListScreen with query parameters
  • Implements MatchListBloc with event/state to fetch, filter, and sort matches
  • Wraps the MatchListScreen in a BlocProvider and updates related UI components

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
lib/router.dart Registers matchList route with query parameters
lib/presentation/match_team_info/screens/match_team_screen.dart Wraps existing layout in SafeArea
lib/presentation/match_list/screen/match_list_screen.dart Integrates MatchListBloc and updates UI for loading and displaying matches
lib/presentation/match_list/bloc/match_list_event.dart Renames event to LoadItems, adds SortOrder
lib/presentation/match_list/bloc/match_list_bloc.dart Implements API call, filtering, and sorting logic
lib/presentation/match_detail/widget/match_participant_widget.dart Fixes incorrect hardcoded redOrBlue parameter
lib/presentation/home/widgets/match_card/match_card_component.dart Wraps team name Text in Expanded for ellipsis
lib/presentation/home/widgets/appbar/home_appbar.dart Replaces hardcoded date with DateTime.now()
lib/presentation/community/screen/community_main_screen.dart Uses LoadingIndicator and refactors filter tap
Comments suppressed due to low confidence (2)

lib/presentation/match_list/bloc/match_list_bloc.dart:27

  • Consider adding unit tests for _onLoadItems to verify API integration, filtering, and sorting behaviors.
Future<void> _onLoadItems(

lib/presentation/match_list/bloc/match_list_event.dart:5

  • [nitpick] The event name LoadItems is generic. Consider renaming to FetchMatchList or LoadMatchList for clearer intent.
class LoadItems extends MatchListEvent {


if (event.gameType != null) {
filtered =
filtered.where((e) => event.gameType == event.gameType).toList();
Copy link

Copilot AI May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filter predicate compares event.gameType to itself, which is always true. It should compare each item's gameType, e.g., e.gameType == event.gameType.

Suggested change
filtered.where((e) => event.gameType == event.gameType).toList();
filtered.where((e) => e.gameType == event.gameType).toList();

Copilot uses AI. Check for mistakes.
@team-gogo team-gogo deleted a comment from Copilot AI Jun 3, 2025
answad added 4 commits June 3, 2025 19:11
…listpage-battingModal-api-connaction

# Conflicts:
#	lib/presentation/match_team_info/screens/match_team_screen.dart
#	lib/router.dart
…ngModal-api-connaction' into feature/#174-matchlistpage-battingModal-api-connaction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

matchListpage, λ² νŒ… λͺ¨λ‹¬ api μ—°κ²°

4 participants