match date 순으로 정렬 및 match 자세히 보기 클릭 시 date 초기화 이슈 해결 #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gsm-gogov3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
|
기존에 localstorage에 저장을 하게 되면 사용자가 자세히보기를 누른 후 -> 브라우저 종료 -> 다시 접속시 기존에 localstorage에 값이 남아있어 오늘의 날짜가 아닌 전에 선택한 날짜가 지정되어 있을 것 같아요 2025-04-28.8.17.07.mov |
Ethen1264
reviewed
Apr 28, 2025
src/shared/ui/match/index.tsx
Outdated
|
|
||
| localStorage.setItem('matchStatus', JSON.stringify(matchStatusData)); | ||
| localStorage.setItem('match', JSON.stringify(matchData)); | ||
| sessionStorage.setItem('selectDate', JSON.stringify(selectDate)); |
Contributor
There was a problem hiding this comment.
이렇게 date만 하면 stage별로 구분이 안 되어서 a stage에서 date를 설정해서 세션에 저장을 하면 b stage에도 동일하게 반영되어 버리는 문제가 생길 것 같아요
Contributor
2025-04-28.8.25.01.mov이렇게 date의 항목 위치를 변경하고 뒤로 가기를 하면 날짜에 아무것도 선택되지 않는 문제가 있어요 |
Contributor
2025-04-28.8.28.22.mov현재 날짜의 매치로 들어가면 세션에 ""로 저장이 되어버리는 문제가 있어요 |
Contributor
Author
수정했습니다 9ea7715 |
Contributor
Author
빈 문자열일 경우 조건식 추가했습니다! 9b6c16b |
Ethen1264
approved these changes
Apr 28, 2025
976520
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 배경 및 개요
match date 순으로 정렬 및 match 자세히 보기 클릭 시 date 초기화 이슈 해결
📃 작업내용
match date 순으로 정렬 및 match 자세히 보기 클릭 시 date 초기화 이슈 해결
2025-04-28.8.07.44.mov