-
Notifications
You must be signed in to change notification settings - Fork 0
Fix/#117 UI qa #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix/#117 UI qa #131
Changes from 23 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
6236b0b
[fix/#117] ํ๋จ ํจ๋ฉ ์์
jyvnee ad14754
[fix/#117] ํ ๋ฐฐ๋ ํด๋ฆญ ์ญ์
jyvnee 268bb9f
[fix/#117] ๋ก๊ณ ์์
jyvnee 1aeb498
[fix/#117] ๋ก๊ณ ์์
jyvnee a5bef6c
[fix/#117] ๋ง์ดํ์ด์ง -> ์ํฐ์คํธ ์ ํ ์ด๋ ์ญ์
jyvnee 1c2b1f9
[fix/#117] ์ํฐ์คํธ ๊ฒ์ ํจ๋ฉ ์์
jyvnee b40b63f
[fix/#117] ๋๋ค ์ด๋ฆ ์์
jyvnee e0101cc
Merge branch 'develop' into fix/#117-ui-qa
jyvnee b7a20c0
[fix/#117] ํ๋ฉด ์ด๋ ํ๋ผ๋ฏธํฐ ์์
jyvnee 3eacd3c
[fix/#117] user dto ์์
jyvnee 68d10f5
[fix/#117] ์ฐธ์ฌ/๋ถ์ฒ ๋ด์ญ ์ด๊ธฐ ์ํ ์ค์
jyvnee 6c30748
Merge branch 'develop' into fix/#117-ui-qa
jyvnee d15ef9b
[fix/#117] ํจํค์ง ๋ถ๋ฆฌ
jyvnee f8b166c
[fix/#117] ๋ถ์ฒ ๋ด์ญ id ๋ฌธ์ ์์
jyvnee a948c49
[fix/#117] ํ๋กํ
๋ฒํผ ํจ๋ฉ ์์
jyvnee 885e721
[fix/#117] ๋ค๋ฅธ ๊ตฟ์ฆ ๊ตฌ๊ฒฝํ๊ธฐ ์ฐ๊ฒฐ
jyvnee d86eb33
Merge branch 'develop' into fix/#117-ui-qa
jyvnee 2b03da5
[fix/#115] ์ํฐ์คํธ nullable ๋ณ๊ฒฝ
jyvnee f75b196
[fix/#115] ์ถ์ฒ ๊ตฟ์ฆ ํค๋ ์์
jyvnee d90c797
[fix/#117] ๊ธ์ ์์
jyvnee 50f2ea8
[fix/#117] ํ์ด์ง๋ค์ด์
๊ฐ์ ์์
jyvnee 5edc885
[fix/#117] ๊ฐ๊ฒฉ ํฌ๋งทํ
jyvnee 86fc277
[fix/#117] ์๋ก๊ณ ์นจ
jyvnee 7065a39
[fix/#117] ๋ฐ์ดํฐ ๋ก๋ ์์
jyvnee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 6 additions & 6 deletions
12
app/src/main/java/com/poti/android/domain/model/home/HomeContent.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...droid/domain/model/party/GoodsCategory.kt โ ...oid/domain/model/party/ProductCategory.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๐งฉ Analysis chain
๐ Script executed:
Repository: team-poti/POTI-ANDROID
Length of output: 157
๐ Script executed:
cat -n app/src/main/java/com/poti/android/presentation/history/manage/ParticipantManageScreen.kt | head -60Repository: team-poti/POTI-ANDROID
Length of output: 3489
๐ Web query:
androidx.lifecycle.compose LifecycleEventEffect ON_RESUME first composition behavior documentation๐ก Result:
LifecycleEventEffect(Lifecycle.Event.ON_RESUME)does not โfire on first compositionโ just because the owner is already inRESUMED.Per the docs, when
LifecycleEventEffectenters the composition it installs aLifecycleEventObserver, and youronEventruns only when the lifecycle subsequently receives that specificLifecycle.Event(i.e., itโs event-driven, not โreplay current stateโ). [1]So, if the composable is first composed while the
LifecycleOwneris already resumed, theON_RESUMEcallback typically wonโt run until the next actual resume transition (after a pause/stop, etc.).If you need โrun immediately if already resumed, and also on future resumesโ, base it on lifecycle state (e.g.,
currentStateAsState()/currentStateFlow) rather than only events. [1]Sources: Android โIntegrate Lifecycle with Composeโ (Lifecycle effects +
currentStateAsState) [1]; Android โSide-effects in Composeโ (registering aLifecycleEventObserverviaDisposableEffect, which similarly only reacts to events as they occur) [2].์ด๊ธฐ ์ง์ ์
ON_RESUME์ด๋ฒคํธ ๋ฐ์ ์ฌ๋ถ ํ์ธ ํ์ํฉ๋๋ค.LifecycleEventEffect(Lifecycle.Event.ON_RESUME)๋ ์ด๋ฒคํธ ๊ธฐ๋ฐ์ผ๋ก ๋์ํ๊ธฐ ๋๋ฌธ์, ์ปดํฌ์ ๋ธ์ด ์ด๋ฏธ RESUMED ์ํ์ธ ๋ผ์ดํ์ฌ์ดํด์์ ์ฒ์ ๊ตฌ์ฑ๋ ๋๋ ์ฝ๋ฐฑ์ด ์คํ๋์ง ์์ต๋๋ค. ๋ค์ resume ์ ํ(pause/stop ํ ์ฌ๊ฐ)์ด ๋ฐ์ํ ๋๋ง ์๋ํฉ๋๋ค.๋ฐ๋ผ์ ์ด ํ๋ฉด์ ์ต์ด ์ง์ ํ์ ๋ ๋ฐ์ดํฐ ๋ก๋ฉ์ด ํ์ํ๋ค๋ฉด:
init๋ธ๋ก์ด๋ ๋ค๋ฅธ ๋ฉ์ปค๋์ฆ์์ ์ด๊ธฐ ๋ก๋๊ฐ ๋ฐ์ํ๋์ง ํ์ธํ๊ฑฐ๋Lifecycle.State.RESUMED์ํ ๊ธฐ๋ฐ์ผ๋ก ๊ฐ์งํ๋ ๋ฐฉ์์ผ๋ก ๋ฆฌํฉํฐ๋ง์ ๊ณ ๋ คํด ์ฃผ์ธ์.ํ์์
currentStateAsState()๋ฅผ ํ์ฉํด ๋ผ์ดํ์ฌ์ดํด ์ํ๋ฅผ ๊ตฌ๋ ํ๋ ๋ฐฉ์๋ ๊ณ ๋ คํ ์ ์์ต๋๋ค.๐ค Prompt for AI Agents