[FIX] 1.shimmer show wrong when fix layout changed 2. stop when #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invisible and autoStart when visible
Contributor
|
@woyunowuyuda thanks for the PR! However, the second issue you are fixing is already in the library. The |
Author
|
@veghtomi sorry for that.I deleted the visibility code. |
|
I've fixed the same problem here: #57 |
Author
|
@VitalyNikonorov I think this would be different.You can check it out by change the TextView#textSize. |
Contributor
|
Sorry guys, I have been quite busy. At the weekend I will check the merge request and allow one of it! Thanks for the patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR fix two things：
Thank for review and forward to deep discuss.