-
Notifications
You must be signed in to change notification settings - Fork 4
WEBRTC 2590 Demo app design improvement #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
WEBRTC 2590 Demo app design improvement #510
Conversation
Co-authored-by: openhands <[email protected]>
* WEBRTC-2592: Home Screen Unregistered Profile UI Change - Set background color to #FEFDF5 - Added 108px spacing between logo and text - Updated socket status text to use sentence case - Added 24px padding on both sides for text elements - Added 32px padding between field items - Updated 'Switch Profile' to sentence case and made it use secondary button style - Set 100px radius and 32px height for buttons - Added version text at bottom with color #525252 * feat: compose app Home Screen refactored * feat: xml app Home Screen refactored --------- Co-authored-by: openhands <[email protected]> Co-authored-by: wojciechowskiradek <[email protected]>
* WEBRTC-2594: Add Profile UI Change - Replaced MaterialSwitch with custom toggle button style - Added 'Add new profile' heading and 'production' text - Added field labels above each TextInputLayout - Styled input fields with 1px border, proper colors, and dimensions - Changed 'Confirm' button to 'Sign In' and repositioned buttons * feat: XML layout improved * feat: compose layout improved * feat: hide / show password for compose * chore: code refactor --------- Co-authored-by: openhands <[email protected]> Co-authored-by: wojciechowskiradek <[email protected]>
* WEBRTC-2596: [Android] Home Screen Active Call UI Change Added toggle buttons for 'Phone number' and 'SIP address' options in both XML and Compose apps. The toggle buttons change the keyboard type when the user focuses on the destination input field. - In XML app: Added MaterialButtonToggleGroup with two buttons at the top of the home call screen - In Compose app: Added DestinationTypeSwitcher composable with two toggle buttons - Added string resources for the toggle button labels - Implemented the logic to change the input type based on the selected option * feat: UI test refactored and improved --------- Co-authored-by: openhands <[email protected]> Co-authored-by: wojciechowskiradek <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As expected, I think we need to steer clear from the designers.
The fact that I need to scroll to hit call and can hit disconnect is horrible.
I know none of this is your fault @wojciechowskiradek you were just following the figma designs but they really aren't translating well from the static figma images.
Here are some changes I would request:
Login:
- Padding on login screen below logo is way too big like you flagged
- Padding between information on login screen is also too large
- Production text in the bottom sheet should be gray
- The text in the button when entering Credential Login or Token Login should not say 'Sign In', but instead 'Confirm'. We are not signing in there, we are setting a config.
Home:
- Again padding between logo and text and the info below it is crazy. This should be reduced so we don't need to scroll to find the call button
- The green circle for Socket and Call State info should be the same (one is darker than the other)
Call:
- When we are on a call we should hide the destination green switch between phone number and SIP Address (this is actually in the figma and isn't included)
- The text box should be filled with the number or sip name from the invite. See here:
I want to be clear here, none of this is bad implementation but instead the static figma designs do not translate well here. Even in the image above you can see the intended view is meant to be closer together and not like this:

I think in general this redesign should really just be:
- Implementing the icons they want
- Adding the green switches they want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general if possible. No Scrolling!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TLDR;
- Keep the green switcher for SIP Address -> Phone number and Token -> Credential
- Keep the icons
- Keep the SDK and App version text at the bottom
- Remove everything else to the old padding values
- Fix the call state so when we are on a call we hide the destination switcher and have the caller SIP name or number (depending on what is in the call object) in the edit text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 Last minor change:
Can we reduce the padding between the Session ID and the controls underneath it (Either the Phone SIP switcher or the phone controls).
t seems to be double that of the other padding of the info above it.
WebRTC-2590 - Demo App Design Improvement
Contains all changes described here:
https://www.figma.com/design/a9KGD1pCvmxbqyq1bESFGc/Telnyx_WebRTC-App_2024-25?node-id=529-4295&p=f&t=eiK4Kb2oyVByk4Qz-0