Skip to content

feat(deps): update bitdev generator templates and teambit dependencies#10284

Open
davidfirst wants to merge 6 commits intomasterfrom
update-bitdev-generators-and-deps
Open

feat(deps): update bitdev generator templates and teambit dependencies#10284
davidfirst wants to merge 6 commits intomasterfrom
update-bitdev-generators-and-deps

Conversation

@davidfirst
Copy link
Copy Markdown
Member

Update bitdev generator templates to latest major versions:

  • bitdev.react/generators/react-templates v6.0.2
  • bitdev.node/generators/node-templates v6.0.1
  • bitdev.symphony/generators/symphony-templates v5.0.1

Also bumps bitdev starters and various teambit UI/tooling dependencies.

Update bitdev generator templates to latest major versions:
- react-templates v6.0.2, node-templates v6.0.1
- symphony-templates v5.0.1, mdx-templates v1.0.14
Also bump bitdev starters and various teambit UI/tooling deps.
Copilot AI review requested due to automatic review settings April 10, 2026 14:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the workspace dependency policy to align Bit’s generator templates/starters and several @teambit UI/tooling packages with newer major/minor versions, as part of keeping the Bit workspace scaffolding and UI stack current.

Changes:

  • Bump @bitdev/* generator templates and starters to newer major versions (React/Node/Symphony).
  • Update a set of @teambit/* UI/tooling dependencies (e.g., base-ui, bvm, defender, preview, etc.).

@davidfirst davidfirst enabled auto-merge (squash) April 10, 2026 14:39
Copilot AI review requested due to automatic review settings April 10, 2026 15:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings April 10, 2026 16:37
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

@davidfirst
Copy link
Copy Markdown
Member Author

Root cause analysis: dedupePaths crash

The dedupePaths function in workspace-config-files has always assumed that when a config writer exists, there will be at least one extending config file generated with component paths. This assumption breaks with the new react-starters v2.0.0.

Old starters (v1.x): Created sample React components (button, app, etc.) that used teambit.react/react-env. That env generates extending config files for all its writers (typescript, eslint, prettier), so dedupePaths always had non-empty paths.

New starters (v2.0.0): Only creates a custom env component (envs/my-react-env) using the base teambit.envs/env. That base env registers an eslint config writer, but generateExtendingFile() returns undefined for it — so the extending config files map is empty. dedupePaths is then called with no component paths, but "." (root dir) is still added as a possible directory. Math.max(...[]) evaluates to -Infinity, causing the crash.

The fix adds an early return in dedupePaths when there are no component paths to process.

@GiladShoham GiladShoham disabled auto-merge April 13, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants