Skip to content

fix(graphql): prevent Apollo cache normalization of Aspect type causing env contamination #10285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luvkapur merged 4 commits into from
Apr 15, 2026
+12 −3
Merged

fix(graphql): prevent Apollo cache normalization of Aspect type causing env contamination #10285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dfa959e
prevent apollo cache normalization of aspect type
luvkapur Apr 10, 2026
00094bc
increase resources to prevent ci failures
luvkapur Apr 10, 2026
fef9c34
Merge branch 'master' into investigate-add-component-ws
luvkapur Apr 14, 2026
afb1104
Merge branch 'master' into investigate-add-component-ws
luvkapur Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,8 +668,8 @@ jobs:
# ========== Bit CI Jobs ==========
bit_pr:
# uncomment in case this job fails with "Killed".
# resource_class: 2xlarge
resource_class: xlarge
resource_class: 2xlarge
# resource_class: xlarge
<<: *defaults
environment:
# BIT_FEATURES: cloud-importer-v2
Expand Down
11 changes: 10 additions & 1 deletion scopes/harmony/graphql/graphql.ui.runtime.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,16 @@ export class GraphqlUI {
}

private createCache({ state }: { state?: NormalizedCacheObject } = {}) {
const cache = new InMemoryCache();
const cache = new InMemoryCache({
typePolicies: {
// The Aspect type has an `id` field (the aspect ID, e.g. "teambit.envs/envs").
// Without this, Apollo normalizes all Aspect objects by __typename:id, causing
// every component to share a single cache entry per aspect ID. This means the
// last-written aspect data overwrites all others (e.g. all components show the
// same env). Disabling normalization stores aspects inline per component.
Aspect: { keyFields: false },
},
});

if (state) cache.restore(state);

Expand Down