feat(application): forward args after -- to bit run apps#10357
Open
davidfirst wants to merge 3 commits intomasterfrom
Open
feat(application): forward args after -- to bit run apps#10357davidfirst wants to merge 3 commits intomasterfrom
-- to bit run apps#10357davidfirst wants to merge 3 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the bit run command to forward any arguments provided after -- (captured via the CLI _packageManagerArgs hook) into the args string passed through to the application run context, enabling per-invocation app flags without requiring env vars or explicit app-side option wiring.
Changes:
- Add
_packageManagerArgssupport toRunCmdand merge CLI--trailing args into the forwardedargsstring. - Pass the merged args string into
ApplicationMain.runApp().
Comment on lines
+82
to
+84
| // merge any args passed after `--` (e.g. `bit run my-app -- --device --ios`) into the args string forwarded to the app. | ||
| const extraArgs = this._packageManagerArgs.join(' '); | ||
| const mergedArgs = [args, extraArgs].filter(Boolean).join(' '); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anything passed after
--onbit runis now collected via the CLI's_packageManagerArgshook and merged into theargsstring forwarded to the app's run context.Enables dynamic per-invocation flags (e.g. React Native
--device,--ios) without env vars or app-side option declarations: