fix(config-store): write the global config with 0600 permissions#10360
Open
davidfirst wants to merge 2 commits intomasterfrom
Open
fix(config-store): write the global config with 0600 permissions#10360davidfirst wants to merge 2 commits intomasterfrom
davidfirst wants to merge 2 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the on-disk permissions for Bit’s global config file (config.json under the global cache dir), which can contain sensitive values like user.token. It ensures the file is written with owner-only permissions (0600) instead of inheriting potentially permissive defaults from the system umask.
Changes:
- Introduce a
CONFIG_FILE_MODE = 0o600constant for the global config file. - Update
GlobalConfig.write()to write with{ mode: 0o600 }and then explicitlychmodto 0600 (to cover pre-existing files). - Update
GlobalConfig.writeSync()similarly (write with mode +chmodSync).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The global config holds the user's
user.tokenbut is written without amodeoption, so it inherits the default umask (often0644). Tighten to0600(matches AWS CLI / gcloud / kubectl / gh).Same shape as
server-port.txthardening from #10344 — passmode: 0o600on write and explicitlychmodafter, since Node only honors themodeoption on file creation.