fix: daylight savings#66
Open
Xyedo wants to merge 3 commits into
Open
Conversation
|
I've discovered an edge case where this does not work: If you have a Test added to func TestDailyDST(t *testing.T) {
sydney, _ := time.LoadLocation("Australia/Sydney")
r, _ := NewRRule(ROption{
Freq: DAILY,
Count: 3,
Dtstart: time.Date(2023, 4, 1, 9, 0, 0, 0, sydney),
})
want := []time.Time{
time.Date(2023, 4, 1, 9, 0, 0, 0, sydney),
time.Date(2023, 4, 2, 9, 0, 0, 0, sydney),
time.Date(2023, 4, 3, 9, 0, 0, 0, sydney),
}
value := r.All()
if !timesEqual(value, want) {
t.Errorf("get %v, want %v", value, want)
}
}Running it gives us the following error: I believe for |
This reverts commit c969eda. chore: revert back to original solution and add fixes
Fix/daylight savings
Author
|
I think for FREQ hourly, minutely, and secondly we need to add with time duration, so the duration is fixed, but with FREQ Daily, Weekly, and Monthly, we follow the time provided by the DTSTART and then add the Date. |
|
This change appears to work. Awesome job @Xyedo! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixing this issues: #63
and appending the testcase on #64:
By letting golang time package calculate the daylight savings by changing it to time.Duration and add it to the existing Date