fix: preserve user-specified order for BYHOUR/BYMINUTE with BYSETPOS#69
Open
hatsumihayashi wants to merge 2 commits into
Open
fix: preserve user-specified order for BYHOUR/BYMINUTE with BYSETPOS#69hatsumihayashi wants to merge 2 commits into
hatsumihayashi wants to merge 2 commits into
Conversation
Add tests to verify that BYSETPOS correctly references positions in the timeset when BYHOUR and BYMINUTE values are specified in non-chronological order. These tests ensure the fix in commit 82c9f20 (remove sort for timeset) works correctly and prevents regression. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using
BYSETPOSwithBYHOURandBYMINUTE, the library produces incorrect results.Example
With this RRULE:
Expected: 03:45, 06:15 (1st and 4th occurrences)
Actual: 03:15, 06:45
Cause
The library sorts BYHOUR and BYMINUTE values internally before generating the timeset, which changes the order of occurrences and causes BYSETPOS to select wrong positions.
Reference
Solution
Remove the unnecessary sorting of BYHOUR/BYMINUTE values to preserve the original order when applying BYSETPOS.