Fix login method chooser #2111
Merged
Fix login method chooser #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Privacy.OnlyShowActualLoginMethods config setting is enabled and the user has no password or passwords are disabled the password option must not be available in the login method chooser.
When Privacy.OnlyShowActualLoginMethods config setting is enabled and the user has either no email address or emails are disabled or emails can not be used for authentication, the passcode option must not be available in the login method chooser.
bjoern-m
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the login method chooser when
privacy.only_show_actual_login_methodsis set totrue. When the user had no password the password option was still present, but must not. Also whenemail.use_for_authenticationis set tofalse, the passcode option was still present, but must not.