fix: remove duplicate vulpekin localizations - #987
Merged
Conversation
we're doubling down babyyyy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tackles a bunch of issues with vulpekin localizations! We had duplicates from our Delta-V days, and had also aggressively renamed most of them to match us calling vulps "vulpekin". When upstream kindly implemented the foxgirls on a broader scale, we wound up with massive warningspam.
I've commented out the redundant Delta-V marking localizations (but kept them in there so we can see what we scrubbed) and renamed the upstream localizations to name the proper species.
I also fixed the vulpekin plushie to have the right name.
Test plan
I hopped into character creation, and all the markings' names work just fine now.
Changelog
🆑