feat: Expand and Clean Up Species Heights - #988
Open
KoboldCatgirl wants to merge 2 commits into
Open
Conversation
…s heights along five ranges: Rodentia, Felinid/"MaxDuffelable", Smallish, Average, and Oni. Expands most species height ranges in both directions. - Harpies can now be a bit taller, and onis a bit shorter, if they choose. - Slightly reduces how short humans can get (0.75-1.1 to 0.8-1.1) - Slightly shrinks slimes (0.85-1.15 to 0.8-1.1)
…e, clarified comments - fixed some commented-out baseScales on deltaV species for bookkeeping (they weren't properly indicated) - placed species in six categories: Tiny, Small, Slight, Average, Malleable, Large.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(By request, onis' minimum height has been brought to 1.1, and slimes' maximum height has been restored to 1.15. Direction discussion is in Phase 2 and ongoing.)
This PR removes baseScale from all species prototypes and goes all-in on minHeight and maxHeight as the sole determining datafields.
It also standardizes species heights along five ranges:
This has the general effect of increasing all species' ranges in both directions, with the following exceptions:
Finally, this will likely eliminate the curious "tiny cyborg" phenomenon, which likely came about due to characters with non-1.0 baseScales spawning in as cyborgs.Tested, and this is incorrect! Cyborg size is based on height, not scale. Silly of me to assume.Why / Balance
The problem with baseScale is that it turns height for many species into a confusing math problem. You can't just slide a felinid's height and know her height in relation to a human--the scale will say "0.9", but it's not actually 0.9 of average, it's 0.9 of average for a felinid, which is 0.85 of average for most species.
Media
Changelog
🆑